Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC - 5123] feat: added new isAggregator and aggregates fields to Onboarding Objects #317

Merged
merged 5 commits into from
Jun 18, 2024
Merged

[SELC - 5123] feat: added new isAggregator and aggregates fields to Onboarding Objects #317

merged 5 commits into from
Jun 18, 2024

Conversation

gianmarcoplutino
Copy link
Contributor

List of Changes

Added isAggregator and aggregates field to:

  • Onboarding (ms module)
  • Onboarding (function module)
  • OnboardingBaseRequest

Motivation and Context

These fields are necessary for the new onboarding flow for aggregator institution that will be implemented to work correctly

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added functions Changes are related to functions onboarding-ms labels Jun 18, 2024
@gianmarcoplutino gianmarcoplutino marked this pull request as ready for review June 18, 2024 13:12
@gianmarcoplutino gianmarcoplutino requested a review from a team as a code owner June 18, 2024 13:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@gianmarcoplutino gianmarcoplutino merged commit b0e40ed into main Jun 18, 2024
9 of 11 checks passed
@gianmarcoplutino gianmarcoplutino deleted the feature/SELC-5123 branch June 18, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuraf manuraf manuraf approved these changes

Assignees
No one assigned
Labels
functions Changes are related to functions onboarding-ms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gianmarcoplutino @manuraf